[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

Mon Mar 20 14:05:26 PDT 2023

kadircet added a subscriber: sammccall.
kadircet added a comment.

In D145843#4207101 <https://reviews.llvm.org/D145843#4207101>, @nridge wrote:

> My understanding is that a more elaborate configuration scheme has been proposed in https://github.com/clangd/clangd/issues/1367, and the feedback there was (quoting Sam from this comment <https://github.com/clangd/clangd/issues/1367#issuecomment-1322018307>):
> The approach taken in this patch seemed to me to be in line with this direction of a "simple config-based solution".

I am afraid this approach is a little "too simple". The intent on @sammccall 's comment there is probably around getting rid of the re-writing of include spellings completely, not for specifying quoted or system includes based on the include spelling.
Even if not, I feel like my argument above still applies. I still can't think of many projects benefiting from always using angles/quotes for include spellings.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145843/new/

https://reviews.llvm.org/D145843