[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

In D141671#4050928 <https://reviews.llvm.org/D141671#4050928>, @ilya-biryukov wrote:

> There is potentially a way to move less code by keeping all declarations at place and only moving bodies of definitions of constructors and destructors to the `.cpp` file.
> Not sure what's preferable (less code moves vs more functions inline in the header), @kadircet do you have an opinion?

Having as few code in headers as possible is the general style guide in LLVM, so I'd rather err towards that and put definitions out-of-line as much as possible. Therefore if we can getaway by just moving definitions out-of-line, while keeping rest of the header ordering the same, let's go with that if it's feasible


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141671/new/

https://reviews.llvm.org/D141671