[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 13 02:54:09 PST 2023


ilya-biryukov added a reviewer: kadircet.
ilya-biryukov added a subscriber: kadircet.
ilya-biryukov added a comment.

There is potentially a way to move less code by keeping all declarations at place and only moving bodies of definitions of constructors and destructors to the `.cpp` file.
Not sure what's preferable (less code moves vs more functions inline in the header), @kadircet do you have an opinion?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141671/new/

https://reviews.llvm.org/D141671



More information about the cfe-commits mailing list