[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

Jens Massberg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 13 05:16:14 PST 2023


massberg added a comment.



> Having as few code in headers as possible is the general style guide in LLVM, so I'd rather err towards that and put definitions out-of-line as much as possible. Therefore if we can getaway by just moving definitions out-of-line, while keeping rest of the header ordering the same, let's go with that if it's feasible

Thanks! I will check if I can get a version without reordering.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141671/new/

https://reviews.llvm.org/D141671



More information about the cfe-commits mailing list