[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

Yueh-Ting (eop) Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 29 01:15:01 PST 2022


eopXD updated this revision to Diff 485589.
eopXD added a comment.

Update code based on landing of D140678 <https://reviews.llvm.org/D140678>.

The motivation of this NFC patch comes from the struggle while I was tracing through them. I think the scattered comments of boilerplates with only something slightly different makes the code hard to read, that is why I am gathering the comments together into a sole paragraph. The multi-level if-statement has duplicated actions and gets me confused from time-to-time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140662/new/

https://reviews.llvm.org/D140662

Files:
  clang/include/clang/Basic/riscv_vector.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140662.485589.patch
Type: text/x-patch
Size: 14319 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221229/9c5dfc31/attachment-0001.bin>


More information about the cfe-commits mailing list