[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 26 16:55:34 PST 2022


craig.topper added inline comments.


================
Comment at: clang/include/clang/Basic/riscv_vector.td:862
+      Value *VLOperand = Ops[PtrOperandIdx + 1];
+      Operands.append(NF, PassThruOperand);
+      Operands.push_back(PtrOperand);
----------------
This doesn't look right to me. This append call appends `PassThruOperand` `NF` times. In the non-agnostic case, it needs to append `NF` different values.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140662/new/

https://reviews.llvm.org/D140662



More information about the cfe-commits mailing list