[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads
Zakk Chen via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 29 02:33:23 PST 2022
khchen added a comment.
LGTM. Thanks for clean up code!
================
Comment at: clang/include/clang/Basic/riscv_vector.td:820
+(Address0, ..., Address{NF - 1}, mask, Ptr, VL)
+(Address0, ..., Address{NF - 1}, mask, Maskedoff0, ..., Maskedoff{NF - 1},
+ Ptr, VL)
----------------
nit: there is no unmasked builtin comment here.
================
Comment at: clang/include/clang/Basic/riscv_vector.td:1035
+ Value *StrideOperand = Ops[PtrOperandIdx + 1];
+ Value *VLOperand = Ops[PtrOperandIdx + 2];
+ Operands.push_back(PtrOperand);
----------------
In fact, VLOperand is always coming from `Ops.back()`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140662/new/
https://reviews.llvm.org/D140662
More information about the cfe-commits
mailing list