[PATCH] D136145: [IR][RFC] Restrict read only when cache type of llvm.prefetch is instruction

Ulrich Weigand via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 18 04:06:07 PDT 2022


uweigand added inline comments.


================
Comment at: llvm/test/CodeGen/SystemZ/prefetch-01.ll:18
 
-; Check that instruction write prefetches are ignored.
-define dso_local void @f2(ptr %ptr) {
-; CHECK-LABEL: f2:
-; CHECK-NOT: %r2
-; CHECK: br %r14
-  call void @llvm.prefetch(ptr %ptr, i32 1, i32 0, i32 0)
-  ret void
-}
+; Instruction write prefetches are invalid.
+; define dso_local void @f2(ptr %ptr) {
----------------
If we decide to declare this invalid, then I'd prefer to remove the test instead of commenting it out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136145/new/

https://reviews.llvm.org/D136145



More information about the cfe-commits mailing list