[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

I guess my question is: is there any fundamental reason why we think we **need** to allow `nullptr` children in `Stmt`? What are the places that actually need it?

A quick search shows there are quite a few places in our codebase (many google-internal) that don't check for `nullptr` and are subject to the same breakage.
It seems that having a standard primitive for iterating over only non-null children and using it in almost all of the places is appropriate. I am trying to understand what are the use-cases that have to see those null children.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135257/new/

https://reviews.llvm.org/D135257