[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 7 02:17:18 PDT 2022


kadircet added a comment.

I wasn't claiming that there are legitimate reasons for having null children, I completely agree with your verdict on this one. The only one I can think of is cases like this, i.e. you don't want to perform some analysis if function body has invalid code in it. but i think that should rather be indicated in the container of children, rather than being inferred by traversing the children.

I am just saying that going out and fixing all the statement types that can contain sub-statements is a much bigger effort.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135257/new/

https://reviews.llvm.org/D135257



More information about the cfe-commits mailing list