[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 6 03:24:12 PDT 2022


ilya-biryukov added a comment.

I don't think it's unreasonable to protect against `nullptr` in individual fields. We need **some** value for it and null is a reasonable choice.
However, it feels completely wrong to have `nullptr` in collections. Those should be filtered out upon creation, if possible.
It seems perfectly fine for a collection to have less elements if some of them are invalid.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135257/new/

https://reviews.llvm.org/D135257



More information about the cfe-commits mailing list