[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

Zixu Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 5 13:08:47 PDT 2022


zixuw added a comment.

With the PrintingPolicy fix in https://reviews.llvm.org/D135295 and landed USR fix, the diff within ExtractAPI tests is only the wording with anonymous enums, and we can drop the lit change:

  658c658
  <             "spelling": "(anonymous)"
  ---
  >             "spelling": "enum (unnamed)"
  661c661
  <         "title": "(anonymous)"
  ---
  >         "title": "enum (unnamed)"
  664c664
  <         "(anonymous)"
  ---
  >         "enum (unnamed)"
  706c706
  <         "(anonymous)",
  ---
  >         "enum (unnamed)",
  746c746
  <             "spelling": "(anonymous)"
  ---
  >             "spelling": "enum (unnamed)"
  749c749
  <         "title": "(anonymous)"
  ---
  >         "title": "enum (unnamed)"
  752c752
  <         "(anonymous)"
  ---
  >         "enum (unnamed)"
  794c794
  <         "(anonymous)",
  ---
  >         "enum (unnamed)",

@dang @QuietMisdreavus for this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134813/new/

https://reviews.llvm.org/D134813



More information about the cfe-commits mailing list