[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

Thu Oct 6 01:15:36 PDT 2022

dang accepted this revision.
dang added a comment.

In D134813#3838069 <https://reviews.llvm.org/D134813#3838069>, @zixuw wrote:

> With the PrintingPolicy fix in https://reviews.llvm.org/D135295 and landed USR fix, the diff within ExtractAPI tests is only the wording with anonymous enums, and we can drop the lit change:
>
>   658c658
>   <             "spelling": "(anonymous)"
>   ---
>   >             "spelling": "enum (unnamed)"
>   661c661
>   <         "title": "(anonymous)"
>   ---
>   >         "title": "enum (unnamed)"
>   664c664
>   <         "(anonymous)"
>   ---
>   >         "enum (unnamed)"
>   706c706
>   <         "(anonymous)",
>   ---
>   >         "enum (unnamed)",
>   746c746
>   <             "spelling": "(anonymous)"
>   ---
>   >             "spelling": "enum (unnamed)"
>   749c749
>   <         "title": "(anonymous)"
>   ---
>   >         "title": "enum (unnamed)"
>   752c752
>   <         "(anonymous)"
>   ---
>   >         "enum (unnamed)"
>   794c794
>   <         "(anonymous)",
>   ---
>   >         "enum (unnamed)",
>
> @dang @QuietMisdreavus for this change.

As far as I know this should affect downstream consumers like Swift-DocC. I am happy with these changes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134813/new/

https://reviews.llvm.org/D134813