[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

Zixu Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 5 12:47:56 PDT 2022


zixuw added a comment.

I'm pulling this on top of https://reviews.llvm.org/D135295 to try locally now.



================
Comment at: clang/include/clang/AST/Decl.h:3647
 
+  void printName(raw_ostream &OS, const PrintingPolicy &Policy) const;
+
----------------
nit: missing an `override` here. (`warning: 'printName' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134813/new/

https://reviews.llvm.org/D134813



More information about the cfe-commits mailing list