[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

Ben Langmuir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 4 09:50:47 PDT 2022


benlangmuir added inline comments.


================
Comment at: clang/include/clang/AST/DeclObjC.h:1091
   virtual void collectPropertiesToImplement(PropertyMap &PM,
                                             PropertyDeclOrder &PO) const {}
 
----------------
Can we use the existing `PropertyDeclOrder` instead of changing the map type? Or else get rid of the `PO` parameter to functions using `PropertyMap` if we keep the MapVector?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135118/new/

https://reviews.llvm.org/D135118



More information about the cfe-commits mailing list