[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

[Steven Wu via Phabricator via cfe-commits]

steven_wu accepted this revision.
steven_wu added a comment.

LGTM.

`RemoveDecl` does become more expensive but I don't have better solution. I am also wondering if as follow up we should add an option to `VerifyDiagnosticConsumer` to be location aware (so the diagnostics from a file is emitted in order) to prevent more problem like this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135118/new/

https://reviews.llvm.org/D135118