[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

Tue Oct 4 13:27:35 PDT 2022

akyrtzi added a comment.

In D135118#3833978 <https://reviews.llvm.org/D135118#3833978>, @steven_wu wrote:

> LGTM.
>
> `RemoveDecl` does become more expensive but I don't have better solution.

Luckily AFAICT this is not a "hot" function.

> I am also wondering if as follow up we should add an option to `VerifyDiagnosticConsumer` to be location aware (so the diagnostics from a file is emitted in order) to prevent more problem like this.

Interesting idea! Something to keep in mind.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135118/new/

https://reviews.llvm.org/D135118