[PATCH] D134507: [Clang] add missing ClangABICompat check

Paul Robinson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 23 06:55:05 PDT 2022


probinson added a comment.

Hi @ychen I saw you updated the patch description, thanks.
IIUC, the change causes some difference in the interpretation of particular template stuff.  Would this be clearer if the BEFORE-15/AFTER-15 test cases used the same template construct?  Currently they are different so it's hard to work out the effect of the change.  In particular, naively I see different mangled names which makes me concerned that there _is_ in fact a net change to mangling.

I'll observe that D128745 <https://reviews.llvm.org/D128745> updated the release notes, but not in the most useful way; it cites DRs without any explanation of what they do, and with no links.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134507/new/

https://reviews.llvm.org/D134507



More information about the cfe-commits mailing list