[PATCH] D134507: [Clang] add missing ClangABICompat check
Paul Robinson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 22 18:16:57 PDT 2022
probinson added a comment.
Anytime there's a Clang ABI version check, I have to wonder whether PS4/PS5 need an exception. (And I'm sorry I missed the earlier patches in this series.) We are pretty much locked to however things worked for Clang 3.2.
Is this specific to C++20 (or later)? In that case the question gets more complicated because we don't yet support C++20. But I see the predecessors of this patch are referring to DRs, and as we all know the C++ committee loves to retroactively redefine earlier versions of the language...
So I don't know what to think at the moment. It's late and I don't have the mental energy to pursue this right at the moment.
I'll try to get back and look more closely tomorrow.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134507/new/
https://reviews.llvm.org/D134507
More information about the cfe-commits
mailing list