[PATCH] D134507: [Clang] add missing ClangABICompat check

[Yuanfang Chen via Phabricator via cfe-commits]

ychen added a comment.

In D134507#3811488 <https://reviews.llvm.org/D134507#3811488>, @probinson wrote:

> Would this be clearer if the BEFORE-15/AFTER-15 test cases used the same template construct?  Currently they are different so it's hard to work out the effect of the change.  In particular, naively I see different mangled names which makes me concerned that there _is_ in fact a net change to mangling.

Understood. It is hard because the `BEFORE-15` and `AFTER-15` cases have compilation failures when the ClangABICompat switch is different and checking the IR requires it to compile cleanly. The mangling actually does not change for the same function type. If the mangling changes, then the (instantiated) function type is different at the souce-code level. It is a little bit different from the real ABI that the same source-code construct has a different binary representation (memory/symbol) etc.

> I'll observe that D128745 <https://reviews.llvm.org/D128745> updated the release notes, but not in the most useful way; it cites DRs without any explanation of what they do, and with no links.

Indeed. I'll submit a follow-up patch to improve that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134507/new/

https://reviews.llvm.org/D134507