[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

[Matheus Izvekov via Phabricator via cfe-commits]

mizvekov added inline comments.


================
Comment at: libcxx/test/libcxx/crash.sh.cpp:15
+
+#pragma clang __debug parser_crash
----------------
Mordante wrote:
> The libc++ build seems to be green. I assume it was intended to be red so we can validate the artifact is available in the CI.
If I made it red, this test would fail in one the jobs from the early group, and we would never run the bootstraping job :(

But making it green does not stop it from exporting the artifact, you can go in there in the build results and have a look!


================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:377
         LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}"
+        CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
     agents:
----------------
Mordante wrote:
> Are relative directories allowed?
Yes, it already worked with the flag.

You can check that it's working, even though the bootstrapping pipeline is green, it still exports the artifacts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133082/new/

https://reviews.llvm.org/D133082