[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

[Mark de Wever via Phabricator via cfe-commits]

Mordante accepted this revision.
Mordante added a comment.

Ideally it would be documented these artifacts are now available. However there's no good place in libc++ to document that. I'm working on such a document so I will take care of documenting these artifacts.

LGTM from libc++'s PoV.



================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:377
         LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}"
+        CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
     agents:
----------------
mizvekov wrote:
> Mordante wrote:
> > Are relative directories allowed?
> Yes, it already worked with the flag.
> 
> You can check that it's working, even though the bootstrapping pipeline is green, it still exports the artifacts.
Thanks I see.

Just a hint you can move this job earlier in this file for testing purposes and/or remove jobs you don't want to test. I use this every now and then when I have issues with a specific CI.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133082/new/

https://reviews.llvm.org/D133082