[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

[Mark de Wever via Phabricator via cfe-commits]

Mordante added a comment.

Thanks for working on this! It's really great to get the crash report as an artifact.



================
Comment at: libcxx/test/libcxx/crash.sh.cpp:15
+
+#pragma clang __debug parser_crash
----------------
The libc++ build seems to be green. I assume it was intended to be red so we can validate the artifact is available in the CI.


================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:377
         LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}"
+        CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
     agents:
----------------
Are relative directories allowed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133082/new/

https://reviews.llvm.org/D133082