[PATCH] D124164: [include-cleaner] Include-cleaner library structure, and simplistic AST walking.

CJ Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 28 13:53:52 PDT 2022


CJ-Johnson accepted this revision.
CJ-Johnson added inline comments.


================
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:18
+class ASTWalker : public RecursiveASTVisitor<ASTWalker> {
+  DeclCallback Callback;
+
----------------
Apologies for my ignorance of LLVM style. Should this be named with a trailing underscore? And should it be a private field?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124164/new/

https://reviews.llvm.org/D124164



More information about the cfe-commits mailing list