[PATCH] D124164: [include-cleaner] Include-cleaner library structure, and simplistic AST walking.

[Sam McCall via Phabricator via cfe-commits]

sammccall marked 2 inline comments as done.
sammccall added inline comments.


================
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:18
+class ASTWalker : public RecursiveASTVisitor<ASTWalker> {
+  DeclCallback Callback;
+
----------------
CJ-Johnson wrote:
> Apologies for my ignorance of LLVM style. Should this be named with a trailing underscore? And should it be a private field?
no, LLVM members are named the same way as locals and classes. (Yes, it's awful).

It is already a private field: members of classes are private by default (the difference between classes and structs). Google style requires private members to be after public ones (and thus `private:` is always present), but LLVM doesn't require this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124164/new/

https://reviews.llvm.org/D124164