[PATCH] D124164: [include-cleaner] Include-cleaner library structure, and simplistic AST walking.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 27 05:29:38 PDT 2022


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks, as discussed offline. this mostly LG. there are concerns about more code re-use, especially around handling pragmas but we should probably address them as we go rather than now.



================
Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:42
+  for (Decl *D : AST.context().getTranslationUnitDecl()->decls()) {
+    if (ReferencingFile == SM.getDecomposedExpansionLoc(D->getLocation()).first)
+      walkAST(*D, [&](SourceLocation Loc, NamedDecl &ND) {
----------------
nit: early exit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124164/new/

https://reviews.llvm.org/D124164



More information about the cfe-commits mailing list