[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

Mon Dec 6 08:22:26 PST 2021

aaron.ballman added a comment.

In D114235#3173549 <https://reviews.llvm.org/D114235#3173549>, @mboehme wrote:

> Aaron, have you had any chance to look at this yet?
>
> I added you as a reviewer because you expressed interest in something like this in this discussion: https://lists.llvm.org/pipermail/cfe-dev/2021-October/069097.html
>
> Is there someone else who would be more appropriate to review this?

I've not had the chance, sorry! My review queue is rather full at the moment, so I'm still digging out from under quite a few reviews (around 50 at last count) and it may be a bit before I can give this one the attention it deserves. This one is more complex because we don't do much of any automatic checking for anything about type attributes (tablegen doesn't do much for them currently), and touching the type system can have significant (and surprising) performance impacts, so we need to be particularly careful here. It's definitely on my queue though and I do intend to get to it as soon as I can.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114235/new/

https://reviews.llvm.org/D114235