[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

Martin Böhme via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 6 23:59:08 PST 2021


mboehme added a comment.

In D114235#3173745 <https://reviews.llvm.org/D114235#3173745>, @aaron.ballman wrote:

> I've not had the chance, sorry! My review queue is rather full at the moment, so I'm still digging out from under quite a few reviews (around 50 at last count) and it may be a bit before I can give this one the attention it deserves. This one is more complex because we don't do much of any automatic checking for anything about type attributes (tablegen doesn't do much for them currently), and touching the type system can have significant (and surprising) performance impacts, so we need to be particularly careful here. It's definitely on my queue though and I do intend to get to it as soon as I can.

Thanks for the quick reply!

There's absolutely no rush here -- and I figured you might have a lot on your plate, just wanted to make sure this hadn't dropped through the cracks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114235/new/

https://reviews.llvm.org/D114235



More information about the cfe-commits mailing list