[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai added a comment.

Not super happy with the complexity `DiagnosedError` introduces, want to consider alternatives first.



================
Comment at: clang/lib/Serialization/ASTReader.cpp:3762
+        return llvm::createStringError(std::errc::illegal_byte_sequence,
+                                       "invalid pragma float control record");
       FpPragmaCurrentValue = FPOptionsOverride::getFromOpaqueInt(Record[0]);
----------------
Good copy-paste catch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108268/new/

https://reviews.llvm.org/D108268