[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

[Ben Barham via Phabricator via cfe-commits]

bnbarham added a comment.

In D108268#2958346 <https://reviews.llvm.org/D108268#2958346>, @vsapsai wrote:

> Not super happy with the complexity `DiagnosedError` introduces, want to consider alternatives first.

Ah yes, I wasn't happy with that either but couldn't come up with a decent alternative. I also considered using `DiagnosticError` but we'd need to keep a `DiagStorageAllocator` around in that case.

Honestly I don't love `Error` in general. It'd be nice if DiagnosticsEngine handled multiple in-flight diagnostics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108268/new/

https://reviews.llvm.org/D108268