[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

Ben Barham via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 17 21:25:29 PDT 2021


bnbarham created this revision.
bnbarham added reviewers: vsapsai, dexonsmith.
bnbarham requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Reading the AST block can never fail with a recoverable error as modules
cannot be removed during this phase. Change the return type of these
functions to return an llvm::Error instead, ie. either success or
failure.

NFC other than the wording of some of the errors.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108268

Files:
  clang/include/clang/Serialization/ASTReader.h
  clang/lib/Serialization/ASTReader.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108268.367108.patch
Type: text/x-patch
Size: 33188 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210818/58d5e395/attachment-0001.bin>


More information about the cfe-commits mailing list