[PATCH] D102568: [Driver] Delete -mimplicit-it=

Wed May 19 12:00:03 PDT 2021

MaskRay added a comment.

I think libvpx's ASFLAGS usage is about GNU as, not the driver option.

In D102568#2769296 <https://reviews.llvm.org/D102568#2769296>, @dblaikie wrote:

>> I think "waiting for a few releases" is too much and doesn't improve things (they will notice issues until you remove the option). I can accept "waiting for one major release".
>
> Having fairly broad windows of not breaking backwards compatibility is a fairly reasonable request. Take LLVM itself, for instance - which supports building with Clang back as far as 3.5. (not suggesting we need to have a window that large for every feature/piece of surface area - but that there is scope for fairly wide windows)

I understand the broad Windows and I also strive for this portability.

However, reverting this patch is now a trade-off. It would make x264/openh264's mingw build happy but break musl's arm build (2018-09 ~ 2021-02).
There can be other projects doing detection on both -mimplicit-it and -Wa,-mimplicit-it and will be broken by reverting this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102568/new/

https://reviews.llvm.org/D102568