[PATCH] D102568: [Driver] Delete -mimplicit-it=

Wed May 19 11:59:16 PDT 2021

mstorsjo added a comment.

In D102568#2769267 <https://reviews.llvm.org/D102568#2769267>, @MaskRay wrote:

> I don't mind reverting this temporarily.
> However, reverting this would break musl build.
> musl (since 2018-09) detects both options and will add both if available: `-Wa,-mimplicit-it=never -mimplicit-it=always` will cause a duplicate option failure.
> Can't there be other projects which do similar detection and be broken by having both options?

I'm curious - if it detects both forms and adds both options, why does it add them with contradicting option values? If I understand things correctly, adding both options with matching values isn't an error?

Ok, so now I checked, and it does seem to error out even if they have matching values - that sounds like the real issue to me.

In the meantime, wouldn't it be possible to detect the presence of the other one and check if they match or not, to avoid passing duplicate options to the backend? I can give that a try.

> I think "waiting for a few releases" is too much and doesn't improve things (they will notice issues until you remove the option). I can accept "waiting for one major release".

Ok, that's at least some sort of middle ground. Would fixing the duplicate option issue (as long as they have matching values) open up for keeping both a little bit longer?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102568/new/

https://reviews.llvm.org/D102568