[PATCH] D102568: [Driver] Delete -mimplicit-it=

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added a comment.

In D102568#2769341 <https://reviews.llvm.org/D102568#2769341>, @MaskRay wrote:

> I think libvpx's ASFLAGS usage is about GNU as, not the driver option.

It is indeed for calling a GNU as-like tool, but at https://chromium.googlesource.com/webm/libvpx/+/66c1ff6850fd53bcf5c17247569bea1d700d6247/build/make/configure.sh#1003 it sets `AS="$CC -c"`, which is for cases when using clang-based tools where there's no standalone `as`-like tool to use.

My initial patch for that case looked like this:

  diff --git a/build/make/configure.sh b/build/make/configure.sh 
  index 81d30a16c..526c08d3a 100644 
  --- a/build/make/configure.sh 
  +++ b/build/make/configure.sh 
  @@ -1009,7 +1009,16 @@ EOF 
             if enabled thumb; then 
               asm_conversion_cmd="$asm_conversion_cmd -thumb" 
               check_add_cflags -mthumb 
  -            check_add_asflags -mthumb -mimplicit-it=always 
  +            check_add_asflags -mthumb 
  +            case ${tgt_os} in 
  +              win*) 
  +                # If $AS is $CC, this flag needs to be passed with -Wa. 
  +                check_add_asflags -Wa,-mimplicit-it=always 
  +                ;; 
  +              *) 
  +                check_add_asflags -mimplicit-it=always 
  +                ;; 
  +            esac 
             fi 
             ;; 
           vs*) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102568/new/

https://reviews.llvm.org/D102568