[PATCH] D93938: [clang-format] Fixed AfterEnum handling

MyDeveloper Day via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 8 23:30:54 PST 2021


+1 we are not going to land this with a failing or removed test


On Tue, 9 Mar 2021 at 07:29, Marek Kurdej via Phabricator <
reviews at reviews.llvm.org> wrote:

> curdeius added a comment.
>
> In D93938#2612952 <https://reviews.llvm.org/D93938#2612952>,
> @HazardyKnusperkeks wrote:
>
> > In my opinion you should then, either temporarily deactivate the test,
> or fix the bug first. A failing test blocks the pipeline and confuses
> everyone working on the project.
>
> +1
>
> I got confused about this. I know that there was some discussion about
> this failing test but I thought that the plan was to fix it (as it should).
> Also, that's what one expects in a revision called "Fixed AfterEnum
> handling" :).
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D93938/new/
>
> https://reviews.llvm.org/D93938
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210309/eefdbe6e/attachment.html>


More information about the cfe-commits mailing list