[PATCH] D93938: [clang-format] Fixed AfterEnum handling

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 8 23:29:21 PST 2021


curdeius added a comment.

In D93938#2612952 <https://reviews.llvm.org/D93938#2612952>, @HazardyKnusperkeks wrote:

> In my opinion you should then, either temporarily deactivate the test, or fix the bug first. A failing test blocks the pipeline and confuses everyone working on the project.

+1

I got confused about this. I know that there was some discussion about this failing test but I thought that the plan was to fix it (as it should). Also, that's what one expects in a revision called "Fixed AfterEnum handling" :).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93938/new/

https://reviews.llvm.org/D93938



More information about the cfe-commits mailing list