[PATCH] D85253: [clangd] Show correct hover tooltip for non-preamble macro definition.

Ilya Golovenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 5 07:56:21 PDT 2020


ilya-golovenko added a comment.

I agree the fix is not correct. I will check how it currently works with clangd built from master branch.

I'm not quite sure there should be no tooltip for a `#define`. Such tooltip is not really useful, but at the same time clangd shows tooltips for function declarations/defnitions, namespaces, variables, etc. and not showing it for macro definition will be a little bit inconsistent from my point of view.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85253/new/

https://reviews.llvm.org/D85253



More information about the cfe-commits mailing list