[PATCH] D85253: [clangd] Show correct hover tooltip for non-preamble macro definition.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

> I'm not quite sure there should be no tooltip for a #define. Such tooltip is not really useful, but at the same time clangd shows tooltips for function declarations/defnitions, namespaces, variables, etc. and not showing it for macro definition will be a little bit inconsistent from my point of view.

We actually had a couple users saying those are redundant too. I agree with them mostly, i suppose these are only useful because we talk about the associated namespace/class/accesspecifer. E.g. you can easily figure out what's the class owning a field, and whether it is private/public without worrying traversing upwards.
Who knows, maybe we should only be displaying that information on the declaration/definition of symbols rather than all the stuff that's already probably next to user's cursor (I say probably because you can have declarations coming from macro invocations).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85253/new/

https://reviews.llvm.org/D85253