[PATCH] D85253: [clangd] Show correct hover tooltip for non-preamble macro definition.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

Sigh, (I think) this is working for macros defined in preamble region as a side effect of preamble being loaded separately and before anything in the main file. E.g.

  #define FO^O 1
  #define FOO 2
  
  void foo() { int x = FOO; };

hovering over the first definition of FOO (at carrot) will yield `#define FOO 2`, because that's the latest definition before `main file`.

That being said, I don't really think there's much value in showing the hovercard at definition of a macro, as that's what we show anyways. (showing the surrounding namespace is even worse, but that's a different problem and i thought we've solved it recently, are you sure you are seeing that behaviour with a build from head?).
So I believe you are rather trying to fix the issue of displaying misleading hover info, and if that's the case I think we should rather fix that by not displaying hover infos at the macro definition locations.

WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85253/new/

https://reviews.llvm.org/D85253