[PATCH] D81422: Change filecheck default to dump input on failure

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

I would also expect a simple command line flag to llvm-lit to be able to control this, rather than having to set an environment variable



================
Comment at: mlir/test/mlir-tblgen/op-format-spec.td:1
-// RUN: mlir-tblgen -gen-op-decls -asmformat-error-is-fatal=false -I %S/../../include %s -o=%t 2>&1 | FileCheck %s --dump-input-on-failure
+// RUN: mlir-tblgen -gen-op-decls -asmformat-error-is-fatal=false -I %S/../../include %s -o=%t 2>&1 | FileCheck %s
 
----------------
All of these MLIR tests are microscopic and I don't think this is a representative sample across all the projects. Most testcases are significantly larger, and have hundreds if not thousands of lines of output


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81422/new/

https://reviews.llvm.org/D81422