[PATCH] D81422: Change filecheck default to dump input on failure

Tue Jun 16 14:51:17 PDT 2020

mehdi_amini marked an inline comment as done.
mehdi_amini added a comment.

In D81422#2096643 <https://reviews.llvm.org/D81422#2096643>, @arsenm wrote:

> I would also expect a simple command line flag to llvm-lit to be able to control this, rather than having to set an environment variable

Would you like a lit command line flag that set the environment variable? I think that's easily doable

================
Comment at: mlir/test/mlir-tblgen/op-format-spec.td:1
-// RUN: mlir-tblgen -gen-op-decls -asmformat-error-is-fatal=false -I %S/../../include %s -o=%t 2>&1 | FileCheck %s --dump-input-on-failure
+// RUN: mlir-tblgen -gen-op-decls -asmformat-error-is-fatal=false -I %S/../../include %s -o=%t 2>&1 | FileCheck %s

----------------
arsenm wrote:
> All of these MLIR tests are microscopic and I don't think this is a representative sample across all the projects. Most testcases are significantly larger, and have hundreds if not thousands of lines of output
Well, if this can act as an extra incentive to break-up such large tests, it see it as a win: debugging failing patterns in the middle of such a large test output is not nice regardless.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81422/new/

https://reviews.llvm.org/D81422