[PATCH] D81422: Change filecheck default to dump input on failure

Mon Jun 15 15:30:02 PDT 2020

mehdi_amini added a comment.

In D81422#2093360 <https://reviews.llvm.org/D81422#2093360>, @arsenm wrote:

> The amount of context printed previously was good enough for development use. If I ever can't figure it out from the diff, I want to look at the output completely separate from the terminal.

I have the totally opposite experience: I can't do any debugging efficiently without this option.  Empirically, most new-comers to writing tests with FileCheck (in MLIR, TensorFlow, XLA, IREE, etc.) have been manually adding -dump-input-on-failure hard-coded into the test themselves, which is a pretty good indication.

Having something contextual around the failures would work for me as well: but the previous situation was just not usable for me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81422/new/

https://reviews.llvm.org/D81422