[PATCH] D80454: [Clang][test] fix tests when using external assembler

Fri May 22 15:34:14 PDT 2020

ychen added a comment.

In D80454#2051668 <https://reviews.llvm.org/D80454#2051668>, @MaskRay wrote:

> In D80454#2051527 <https://reviews.llvm.org/D80454#2051527>, @ychen wrote:
>
> > In D80454#2051524 <https://reviews.llvm.org/D80454#2051524>, @aganea wrote:
> >
> > > Could you please attach a test to demonstrate the issue?
> >
> >
> > When a toolchain is not using integrated-as, the test would fail because using external assember would increase job counts. Most toolchains in tree use integrated-as, but we still support external assembler. So this is just making it explicit.
>
>
> This point deserves a comment in the test.

Will do.

> @ychen What is your LLVM_DEFAULT_TARGET_TRIPLE?

All I could say is that it is not a in-tree toolchain and it uses external assembler.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80454/new/

https://reviews.llvm.org/D80454