[PATCH] D80454: [Clang][test] fix tests when using external assembler

Yuanfang Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 22 17:10:07 PDT 2020


ychen added a comment.

In D80454#2051637 <https://reviews.llvm.org/D80454#2051637>, @aganea wrote:

> LGTM.
>
> Are you planning on adding another patch for the change that you've sent initially? Ideally, I'd like to relax a bit that constraint in `Driver.cpp`, as in D74447 <https://reviews.llvm.org/D74447>, but that requires first to disable `-disable-free` to ensure we exit cleanly, at least when runing the tests (a bit like the `LLD_IN_TEST` env var).


Oh, that's not my plan. I think the motivation of D74447 <https://reviews.llvm.org/D74447> makes great sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80454/new/

https://reviews.llvm.org/D80454





More information about the cfe-commits mailing list