[PATCH] D80454: [Clang][test] fix tests when using external assembler

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 22 15:02:17 PDT 2020


MaskRay added a comment.

In D80454#2051527 <https://reviews.llvm.org/D80454#2051527>, @ychen wrote:

> In D80454#2051524 <https://reviews.llvm.org/D80454#2051524>, @aganea wrote:
>
> > Could you please attach a test to demonstrate the issue?
>
>
> When a toolchain is not using integrated-as, the test would fail because using external assember would increase job counts. Most toolchains in tree use integrated-as, but we still support external assembler. So this is just making it explicit.


This point deserves a comment in the test.

@ychen What is your LLVM_DEFAULT_TARGET_TRIPLE?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80454/new/

https://reviews.llvm.org/D80454





More information about the cfe-commits mailing list