[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:233
 
-  bool VisitTypeLoc(TypeLoc TL) {
-    if (auto K = kindForType(TL.getTypePtr()))
----------------
hokein wrote:
> as we are not visiting this base `TypeLoc` in this patch, will we miss any interesting `TypeLoc`s (e.g. FunctionTypeLoc)? 
We didn't do anything interesting with function type locs before this patch as well.
This patch aims to produce equivalent results in all cases except the primitive types (and spell out those cases explicitly by implementing corresponding `Visit*TypeLoc` methods).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69431/new/

https://reviews.llvm.org/D69431