[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:233
 
-  bool VisitTypeLoc(TypeLoc TL) {
-    if (auto K = kindForType(TL.getTypePtr()))
----------------
ilya-biryukov wrote:
> hokein wrote:
> > as we are not visiting this base `TypeLoc` in this patch, will we miss any interesting `TypeLoc`s (e.g. FunctionTypeLoc)? 
> We didn't do anything interesting with function type locs before this patch as well.
> This patch aims to produce equivalent results in all cases except the primitive types (and spell out those cases explicitly by implementing corresponding `Visit*TypeLoc` methods).
ah, yes, thanks for the explanation, I was over-concerned. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69431/new/

https://reviews.llvm.org/D69431