[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 28 02:12:10 PDT 2019


hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:233
 
-  bool VisitTypeLoc(TypeLoc TL) {
-    if (auto K = kindForType(TL.getTypePtr()))
----------------
as we are not visiting this base `TypeLoc` in this patch, will we miss any interesting `TypeLoc`s (e.g. FunctionTypeLoc)? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69431/new/

https://reviews.llvm.org/D69431





More information about the cfe-commits mailing list