[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

Bruno Ricci via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 15 15:04:23 PDT 2019


riccibruno added inline comments.


================
Comment at: include/clang/AST/Stmt.h:100
     unsigned sClass : 8;
+    unsigned IsOMPStructuredBlock : 1;
   };
----------------
What about a comment explaining the purpose of this bit ?


================
Comment at: include/clang/AST/StmtOpenMP.h:274
+  /// Prerequisite: Executable Directive must not be Standalone directive.
+  Stmt *getStructuredBlock() const;
 };
----------------
This is not const-correct. The const-qualified method should return a `const Stmt *`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59214/new/

https://reviews.llvm.org/D59214





More information about the cfe-commits mailing list