[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 15 15:15:45 PDT 2019


lebedev.ri added inline comments.


================
Comment at: include/clang/AST/StmtOpenMP.h:274
+  /// Prerequisite: Executable Directive must not be Standalone directive.
+  Stmt *getStructuredBlock() const;
 };
----------------
riccibruno wrote:
> This is not const-correct. The const-qualified method should return a `const Stmt *`.
Hmm, true; though that is not uncommon for all of clang.
I guess it will be best to return const-qualified here, and add a wrapper that would cast it away.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59214/new/

https://reviews.llvm.org/D59214





More information about the cfe-commits mailing list